[FFmpeg-devel] [PATCH 1/10] GXF Encoder Fixes and HD support (patch broken up)

Baptiste Coudurier baptiste.coudurier
Thu Sep 9 22:31:18 CEST 2010


Hi,

On 09/08/2010 06:34 PM, Reuben Martin wrote:
> Yo, back on Wednesday, September 08, 2010 Reuben Martin was all like:
>> Here's the breakdown:
>>
>> 01-gxf__flt_offset_error.patch
>>
>> BUG: The offset values for the FLT packets were getting attached to the packet preceding the packet they were supposed to be attached to. This was causing all kinds of playback and seeking issues on GrassValley's Turbo.
>>
>>
>>
>> 01-gxf__flt_offset_error.patch
>>
>>
>> --- ffmpeg-old/libavformat/gxfenc.c	2010-09-04 11:41:27.000000000 -0500
>> +++ ffmpeg-new/libavformat/gxfenc.c	2010-09-08 16:39:20.405000084 -0500
>> @@ -878,7 +878,11 @@
>>                   return -1;
>>               }
>>           }
>> -        gxf->flt_entries[gxf->flt_entries_nb++] = url_ftell(pb) / 1024;
>> +
>> +        if (!(gxf->flt_entries_nb))
>> +            gxf->flt_entries[gxf->flt_entries_nb] = 4; /* First offset seems to be pretty close to this. May vary. */
>> +        gxf->flt_entries_nb++;
>> +        gxf->flt_entries[gxf->flt_entries_nb] = url_ftell(pb) / 1024;
>>           gxf->nb_fields += 2; // count fields
>>       }
>>

Looks hackish to me.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org



More information about the ffmpeg-devel mailing list