[FFmpeg-devel] [PATCH] yadif port to libavfitler

Michael Niedermayer michaelni
Fri Sep 10 00:36:22 CEST 2010

On Thu, Sep 09, 2010 at 06:30:47PM -0400, Ronald S. Bultje wrote:
> Hi,
> On Wed, Sep 8, 2010 at 11:50 AM, Stefano Sabatini
> <stefano.sabatini-lala at poste.it> wrote:
> > Updated again. Documentation for the second param should be extended,
> > (Mplayer docs is outdated as well), also maybe ASM code should be
> > placed in /ARCH dirs.
> [..]
> > +                yadif->filter_line(ctx, dst, prev, cur, next, w, refs, parity ^ tff);
> Since the asm code is called as a function pointer, not inlined, I'd
> like to "kindly suggest" that the code be ported to yasm before it is
> committed.

the question remains why?
the bug can be fixed with a single letter change (that be s/g/r/ likely)
rewriting code takes time and risks introducing bugs and requires more time
reviewing, our resources arent all that great for these 1000% bikeshed

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100910/755e80dc/attachment.pgp>

More information about the ffmpeg-devel mailing list