[FFmpeg-devel] [PATCH] remove loop in udp_read

Ronald S. Bultje rsbultje
Thu Sep 16 19:24:36 CEST 2010


Hi,

On Thu, Sep 16, 2010 at 1:16 PM, aviad rozenhek <aviadr1 at gmail.com> wrote:
> On Thu, Sep 16, 2010 at 12:02, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>
>> aviad rozenhek <aviadr1 <at> gmail.com> writes:
>>
>> > - ? ? ? ?len = s->read_packet(s->opaque, dst, len);
>> > + ? ? ? ?do { len = s->read_packet(s->opaque, dst, len); } while(len ==
>> > AVERROR(EAGAIN));
>>
>> Apart from looking ugly, this change (and the one below) should be done
>> without
>> removing a line from the current source.
>>
>> Carl Eugen
>>
>>
> I can split it into 3 lines
> - len = s->read_packet(s->opaque, dst, len);
> + do {
> + ? ? len = s->read_packet(s->opaque, dst, len);
> + } while(len == AVERROR(EAGAIN));
>
> but I don't know how to do it without ?removing a line, as that's not the
> way my "svn diff" rolls

+ do {
  len = s->read_packet(..);
+ } while(len == AVERROR(EAGAIN));

then reindent in a separate patch.

Ronald



More information about the ffmpeg-devel mailing list