[FFmpeg-devel] [PATCH2/3] asfdec.c doesn't detect aspectratio properly in some case
Wed Sep 22 00:49:42 CEST 2010
> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
> Sent: Tuesday, September 21, 2010 3:02 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH2/3] asfdec.c doesn't detect
> aspectratio properly in some case
> On Tue, Sep 21, 2010 at 10:15:38AM -0700, Richard Buteau wrote:
> > Hi all,
> > In some case ASF file don't have aspect ratio set in
> > ff_asf_metadata_header but in ff_asf_extended_content_header.
> > The results was a stretch out file.
> > This patch extract that aspect ratio info and pass it down to the
> > container.
> > Richard
> Content-Description: asfAR.patch.txt
> > diff -uNr -x .svn -x '*.d' ffmpeg/libavformat/asfdec.c
> > --- ffmpeg/libavformat/asfdec.c 2010-09-14 13:04:36.000000000
> > +++ ffmpeg.asfAR/libavformat/asfdec.c 2010-09-21
> > @@ -467,6 +467,12 @@
> > value_len = get_le16(pb);
> > if (!value_type && value_len%2)
> > value_len += 1;
> > + int stream_num=0; //Ideally we should find the
> video stream and set it there. My sample has that stream set to 0
> that mean the container.
> breaks gcc 2.95
> try tools/patcheck please
> and assigning global information to just one stream is wrong
> and please upload the asf file that needs this
If for some reason there is a stream with both ff_asf_metadata_header
and ff_asf_extended_content_header present AR info could get overwritten
if I blindly copied it all over. At Line 641 I passed it down to each
stream that has no AR and is CODEC_TYPE_VIDEO, so this should be safe.
I added a check for CODEC_TYPE_VIDEO and I clean up the errors from
Updated patch attached. (Passed the tools/patcheck)
File uploaded in uploaded in
> Michael GnuPG fingerprint:
> Good people do not need laws to tell them to act responsibly, while
> people will find a way around the laws. -- Plato
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the ffmpeg-devel