[FFmpeg-devel] [PATCH] rawdec: do not unnecessarily allocate full-frame buffer

Reimar Döffinger Reimar.Doeffinger
Thu Sep 23 23:22:15 CEST 2010

On Tue, Sep 21, 2010 at 07:15:53PM +0100, Reimar D?ffinger wrote:
> attached patch makes rawdec.c only allocate a buffer if it will
> actually be used (2 and 4 bpp formats), adding a separate palette
> to the context for use in the general PAL8 case.
> make test passes, and I don't think it should break anything,
> though I'll probably suggest a few more changes in a few days.

Could someone please check if attached patch fixes the issue
with the valgrind test?
It seemed to work for me when I ran valgrind manually on the pixfmt
tests but I don't know how set up the test to run valgrind as on
the fate machine.
In addition I suspect that libavfilter handles paletted formats
suboptimally by always allocating space for and copying a palette
(i.e. using PAL8 layout) even when it is a fixed palette like e.g.
for GRAY8.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rawpal.diff
Type: text/x-diff
Size: 1360 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100923/65721f22/attachment.diff>

More information about the ffmpeg-devel mailing list