[FFmpeg-devel] [FFmpeg-devel-irc] IRC log for 2010-09-17#
Fri Sep 24 22:56:22 CEST 2010
On Fri, Sep 24, 2010 at 09:36:19PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Fri, Sep 24, 2010 at 08:39:37PM +0100, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> > yadif has been approved already ...
> >> By whom?
> > me
> Reviewing our own code now, are we?
better than asking randomly to "just commit it"
> >> There is an awful amount of truly disgusting code in
> >> mplayer, which was some still "approved". Most of mplayer is nowhere
> >> near the standards we require for new submissions to ffmpeg. Moving
> >> filters to libavfilter is a good opportunity to clean them up rather
> >> than turn ffmpeg also into a stinking dung heap.
> > Yes some code in mplayer is of rather poor quality, yadif is not
> > amongth that i know because i happen to be the author of it
> Your code, especially older code, is among the most horrible I have
> ever seen.
now everything makes sense
i was always wondering why configure, the makefiles and all the scripts look
so messy, you dont look at them while writing.
> You being the author provides me no assurance whatsoever
> that the code in question is up to FFmpeg standard. Quite the contrary.
that says something about your personality more than anything else
> > and the patch was alraedy delayed for 2 weeks because of you, you had these
> > 2 weeks to review it you did nothing
> If you were waiting for me, why did you not give me a friendly reminder?
because i wasnt waiting for you
i just saw someone wanting to fork because of it so looked at the thread of
yadif which i remembered that i approved. And found only your unspecific
i want to review it too that was 2 weeks old
if you want to review it noone stop you, but if you dont dont ask for further
iam sure there are minor issues that you will find if you review it but i
dont think any of that merity more weeks of delay.
> > we will not hold all patches from mplayer indefinitly because you have a
> > personal issue with mplayer.
> I don't have a personal issue with mplayer. I have an issue with the
> coding style (or lack thereof) prevalent in mplayer. I do not want to
> see it infiltrate ffmpeg.
That coding style predates yadif by a large margin.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 1
"Used only once" - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel