[FFmpeg-devel] [RFC] stream parsing
Sun Sep 26 14:14:27 CEST 2010
On Sun, Sep 26, 2010 at 12:54:34PM +0200, Benjamin Larsson wrote:
> > this looks strange
> > i would have expected a
> > if((codec->capabilities & CODEC_CAP_CHANNEL_CONF) && !channel_layout)
> > return 0;
> > in has_codec_parameters()
> There is no AVCodec available in has_codec_parameters() only an
> > but maybe this doesnt work for some case?
> It wont work as it's the wrong struct.
> > at least your "if we dont have all parameters remove these 3 parameters"
> > is looking worse
> This is what the AAC codec uses, I'm not saying its correct I just took
> something that worked. But IIRC something need to set these to 0 before
> opening the decoder otherwise it will use the values the demuxer set.
the decoder should override them if they are wrong
for AAC there maybe are further considerations due to SBR
> Anyway I redid the patch, it's abit more logical now but pretty much the
> Btw in has_codec_parameters() there is a list of codecs with some
> special casing, I think these codecs should have this new capability set.
simplifications is welcome
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel