[FFmpeg-devel] [PATCH] Add asrc abuffer - audio source buffer for lavfi
S.N. Hemanth Meenakshisundaram
Mon Sep 27 09:15:50 CEST 2010
Added documentation to asrc-abuffer.h header.
Changed init to accept strtol base 0. (Corresponding change in ffmpeg.c
To answer the rest of Justin's questions:
1. CH_LAYOUT_STEREO has value 0x3 which is less than CH_LAYOUT_MONO
(0x4). Hence it will be accepted.
The front left and front right channels are by themselves not valid
channel layouts in the channel layout table in avcodec.h
Although we can process audio buffers with such layouts, wouldn't it be
better to add those layouts to the list of valid layouts than handle
them individually here?
This is also the problem with allowing the user to specify strings like
CH_FRONT_LEFT|CH_FRONT_RIGHT etc. We would then need to check if the
layout is valid. I can change it if doing the check is preferable to the
current method of using the strings in audioconvert.c for the channel
doc/filters.texi | 51 +++++++++++++
libavfilter/Makefile | 2 +
libavfilter/allfilters.c | 2 +
libavfilter/asrc_abuffer.c | 169 ++++++++++++++++++++++++++++++++++++++++++++
libavfilter/asrc_abuffer.h | 36 +++++++++
5 files changed, 260 insertions(+), 0 deletions(-)
create mode 100644 libavfilter/asrc_abuffer.c
create mode 100644 libavfilter/asrc_abuffer.h
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 10611 bytes
Desc: not available
More information about the ffmpeg-devel