[FFmpeg-devel] [PATCH] 10-bit DNxHD support v4 review request
tempn at twmi.rr.com
Fri Apr 8 02:29:00 CEST 2011
On Thu, 07 Apr 2011 16:25:26 -0700, Baptiste Coudurier wrote:
>On 4/7/11 1:56 AM, Joseph Artsimovich wrote:
>> Baptiste Coudurier wrote:
>>>>>> + assert(nbits < ctx->cid_table->bit_depth + 4);
>>>>> assert would kill the program.
>>>> That would indicate a serious bug. The assert merely checks we
>>>> are not
>>> reading past the end of a table.
>>>> BTW, I've come by the following comment in mpegvideo_enc.c: //non
>>>> c quantize code returns incorrect block_last_index FIXME If still
>>> that could trigger this assert.
>>> It's a problem, but can this actually happen ?
>> It happened to me once while I was in the middle of implementing
>> 10bit support, which made me introduce that assert. It hasn't
>> happened since. I hope it was because I did something wrong back
by 'please check' do you mean run a fuzzer (like zzuf) on a 10bit file
and make sure valgrind doesnt complain ?
More information about the ffmpeg-devel