[FFmpeg-devel] [PATCH] VBR header for "libmp3lame"
Carl Eugen Hoyos
cehoyos at ag.or.at
Sat Apr 16 11:17:52 CEST 2011
Peter Belkner <pbelkner <at> snafu.de> writes:
> The patch allows for writing the VBR header as generated by "libmp3lame.a".
Just two cosmetic remarks, wait for a real review before resending:
> +#define AVCTX_IS_VBR(avctx) ((avctx)->flags & CODEC_FLAG_QSCALE)
This is only used once in the new code, and it implies an additional changed
line, making reading the patch slightly more difficult.
> + if (NULL == data
This style would be very unusual for FFmpeg, please use "!data".
Thanks for you effort, Carl Eugen
More information about the ffmpeg-devel