[FFmpeg-devel] [PATCH] ffplay: rename stream_pause() to stream_pause_resume()

Alexander Strasser eclipse7 at gmx.net
Fri Apr 22 17:44:10 CEST 2011


Hi

Stefano Sabatini wrote:
> The new name is less misleading, since the function will resume the
> stream if it is currently paused.
> 
> Signed-off-by: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> ---
>  ffplay.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/ffplay.c b/ffplay.c
> index c080cc0..1faa60e 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -1064,7 +1064,7 @@ static void stream_seek(VideoState *is, int64_t pos, int64_t rel, int seek_by_by
>  }
>  
>  /* pause or resume the video */
> -static void stream_pause(VideoState *is)
> +static void stream_pause_resume(VideoState *is)
>  {
>      if (is->paused) {
[remaining patch snipped]

  Maybe using the verb to toggle is more concise, e.g. just rename
the function to "stream_toggle_pause".

  Alexander


More information about the ffmpeg-devel mailing list