[FFmpeg-devel] [ffmpeg-devel] [PATCH 2/4] lavfi: add asink_abuffer - audio sink buffer filter

[Stefano Sabatini]

On date Tuesday 2011-08-02 22:03:06 +0300, Mina Nagy Zaki encoded:
> On Tue, Aug 02, 2011 at 12:33:35AM +0200, Stefano Sabatini wrote:
> > On date Monday 2011-08-01 12:35:20 +0300, Mina Nagy Zaki encoded:
> [...]
> 
> Fixed.
> 
> > 
> > > + * @param samplesref pointer to an AVFilterBufferRef* to put buffer
> >                                                          ^^^^^^^^^^^^^
> > typo?
> > 
> > nit++: maybe you can entirely skip the @param, but it would generate a
> > doxygen warning, so do as you prefer.
> > 
> 
> Removed. Also consistent with video sink.
> 
> > > + * @param flags unused
> > > + * @return >= 0 in case of success, a negative AVERROR code in case of failure
> > > + */
> > > +int av_asink_abuffer_get_audio_buffer_ref(AVFilterContext *abuffersink,
> > > +                                          AVFilterBufferRef **samplesref,
> > > +                                          int av_unused flags);
> > > +
> > > +#endif /* AVFILTER_ASINK_ABUFFER_H */
> > 
> > Looks fine otherwise.
> > 
> > Possible todos includes: support for a peek flag like in the video
> > sink, support for multiple frames caching (depends on av_fifo_peek2(),
> > can't yet be implemented).

> From 5fbfb1da319b825b00fde5a65e1cb194a30f7c71 Mon Sep 17 00:00:00 2001
> From: Mina Nagy Zaki <mnzaki at gmail.com>
> Date: Thu, 7 Jul 2011 00:26:16 +0300
> Subject: [PATCH 03/11] lavfi: add asink_abuffer - audio sink buffer filter
> 
> ---
>  doc/filters.texi            |   11 +++++
>  libavfilter/Makefile        |    1 +
>  libavfilter/allfilters.c    |    1 +
>  libavfilter/asink_abuffer.c |  101 +++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/asink_abuffer.h |   47 ++++++++++++++++++++
>  5 files changed, 161 insertions(+), 0 deletions(-)
>  create mode 100644 libavfilter/asink_abuffer.c
>  create mode 100644 libavfilter/asink_abuffer.h

Looks fine to me. I'll apply soon if I see no more replies.
-- 
FFmpeg = Freak and Fundamentalist Mean Ponderous Excellent Guru