[FFmpeg-devel] [PATCH 1/3] lavfi: remove default config_props() callback and refactor avfilter_config_links()
stefano.sabatini-lala at poste.it
Thu Aug 4 19:39:48 CEST 2011
On date Thursday 2011-08-04 19:22:01 +0300, Mina Nagy Zaki encoded:
> On Thu, Aug 04, 2011 at 07:05:22PM +0200, Stefano Sabatini wrote:
> > On date Thursday 2011-08-04 15:47:00 +0300, Mina Nagy Zaki encoded:
> > Looks fine, but you should also remove the declaration in avfilter.h
> > (BTW I noticed that avfilter_default_config_input_link() is never
> > defined).
> The config_props() for inputs is just used to allow filters to react to getting
> linked, a default handler is meaningless.
> I have removed its declaration as well.
OK, though it deserves a separate patch (no need to send it, I'll do
it when applying this one).
> From 2987659729f7ee7595c83e6b013e5d1a2db7ef2f Mon Sep 17 00:00:00 2001
> From: Mina Nagy Zaki <mnzaki at gmail.com>
> Date: Thu, 4 Aug 2011 12:34:05 +0300
> Subject: [PATCH] lavfi: remove default config_props() callback and refactor
> Link properties have to be checked after config_props() is called to make sure
> everything is sane, so the default config_props() for output links was
> redundant, and for input links it is not required (and was never defined)
> Also removed channel_layout check as it is now negotiated.
> libavfilter/avfilter.c | 59 +++++++++++++++++++++++++++++++++++-------------
> libavfilter/avfilter.h | 6 -----
> libavfilter/defaults.c | 23 ------------------
> 3 files changed, 43 insertions(+), 45 deletions(-)
Looks fine to me, going to apply in a few days if I see no comments.
FFmpeg = Fundamental & Fundamentalist Marvellous Proud Exuberant Generator
More information about the ffmpeg-devel