[FFmpeg-devel] [PATCH] lavfi: port libmpcodecs delogo filter

[Nicolas George]

Le quartidi 24 thermidor, an CCXIX, Stefano Sabatini a écrit :
> I see, I was basing the port on the libavfilter/libmpcodecs
> code. Indeed now I see the MPlayer code is different, if my guess is
> right it is supporting option parsing (when was it added?).

Option parsing has been there for a long time. I suppose Michael removed it
when adapting to the lavfi wrapper.

> For the file option we can add it in a second stage (maybe you could
> do it as an exercise?)

Merging the file option would be pretty simple, I can do it once the filter
is committed. The total amount of effort would probably have been slightly
less if it had been merged before you started your porting efforts, but
there is no changing the past, and I am as much to blame as anyone for not
having done it.

> No the parsing code is not changing how the options are parsed, but
> maybe we should use named options here, I mean something like that:
> 
> delogo=x=100:y=0:band=10:w=100:h=70
> 
> which should also provide a more useful feedback in case of invalid
> parameters (but would be inconsistent with the current syntax).

FWIV, MPlayer supports both named and unnamed options. The same could be
easily applied to any filter with both common and rare options:

int av_set_options_string_in_order(obj, str)
{
    if (strchr(args, '='))
	return av_set_options_string(obj, str, "=", ":");
    /* split str on ':' and set the options in the order they appear in the
     * array */
}

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110811/19ee8a23/attachment.asc>