[FFmpeg-devel] [PATCH]Make CH_LAYOUT_5POINTx_BACK the normal case
stefano.sabatini-lala at poste.it
Fri Aug 26 00:07:21 CEST 2011
On date Thursday 2011-08-25 18:01:36 +0000, Carl Eugen Hoyos encoded:
> Stefano Sabatini <stefano.sabatini-lala <at> poste.it> writes:
> > > > > AV_CH_LAYOUT_5POINTx_BACK is what every other application expects for
> > > > > 5.0/5.1 when reading a wav file which is where FFmpeg's channel layout
> > > > > comes from, so this should be the "normal" case, and
> > > > > AV_CH_LAYOUT_5POINTx the exception.
> > > >
> > > > How is this related to the channel_layout_map array?
> > >
> > > How is it not related to it?
> > I see channel_layout_map is used for mapping strings <-> channel
> > layouts, so the only difference I'd expect by this change is that now
> > the mapping is changed. In other words the string is only used for
> > describing the channel layout to *users*, so it is an UI change.
> > Or no?
> I thought when you wrote "This is required for distinguishing between the two
> channel layouts starting from the channel layout description." you meant that
> this will be used in the future by users to request channel layouts that the
> input should be converted into.
Yes, right now the only code which uses the strings is the aformat and
abuffer filters. So I'm not saying that this patch should be dropped,
but that we should fix the macro/string inconsistencies, which is no
hard and doesn't imply any ABI break.
> If I misunderstood, I agree the patch is not that important.
FFmpeg = Frightening Fundamentalist Meaningless Puritan Energized God
More information about the ffmpeg-devel