[FFmpeg-devel] [PATCH] ffplay: fix a crash caused by aborting the video queue

[avcoder]

On Sat, Aug 27, 2011 at 6:09 PM, Marton Balint <cus at passwd.hu> wrote:
>
> On Sat, 27 Aug 2011, avcoder wrote:
>
>> I fail to understand!
>>
>> The following "if(is->videoq.abort_request) " will prevent the code
>> from going through. so there is no any chance to affect
>> VideoState->pictq_windex
>
> Yes, the patch description is probably not entirely correct, sorry, my
> mistake. The thought of changing w_index somehow remained in my mind from
> the time I debugged this.
>
> The main problem with the code is that multiple ALLOC events may occur at
> the same time if we don't pop them from the event queue on abort. If these
> alloc events tries to allocate the same vp, vp->bmp changes (free-d, and the
> then allocated again), I typically got the crash when
> SDL_LockYUVOverlay(vp->bmp) was called from the video thread, after
> SDL_FreeYUVOverlay(vp->bmp) was called from the main thread.
>

Get it, thanks

-- 
-----------------------------------------------------------------------------------------
My key fingerprint: d1:03:f5:32:26:ff:d7:3c:e4:42:e3:51:ec:92:78:b2