[FFmpeg-devel] [PATCH 1/2] ffprobe: introduce output format writers.

Clément Bœsch ubitux at gmail.com
Tue Aug 30 09:35:09 CEST 2011


On Sun, Aug 28, 2011 at 01:01:45PM +0200, Stefano Sabatini wrote:
> [...]
> > From 5bdd793d764af83e1c101f4c178d17aade38cfbc Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> > Date: Sat, 27 Aug 2011 20:19:19 +0200
> > Subject: [PATCH 1/2] ffprobe: introduce output format writers.
> > 
> > ---
> >  ffprobe.c |  295 +++++++++++++++++++++++++++++++++++++++++++-----------------
> >  1 files changed, 211 insertions(+), 84 deletions(-)
> 
> No more comments from me. Just verify the output is not changed in
> significant ways (so scripts relying on the previous behavior won't
> break), maybe just wait one day or two before committing in case other
> devs want to comment on it.
> 

The output shouldn't have changed at all. If it has in some cases, I'll
fix it ASAP.

Pushed, with a slight difference: print_str_f() callback is dropped
(temporarily maybe) because of no use ATM (the print_str helper call
print_fmt anyway)

> And nice work :-).

Thanks, new JSON patch incoming when I'll have time to finish the escaping
properly. Feel free to rewrite the compact view patch before I'm done with
it, it may help changing the "API" soonish if needed.

Thanks for the quick reviews!

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110830/ccb3ba50/attachment.asc>


More information about the ffmpeg-devel mailing list