[FFmpeg-devel] [PATCH] Port tinterlace filter from MPlayer.
michaelni at gmx.at
Tue Aug 30 20:37:36 CEST 2011
On Tue, Aug 30, 2011 at 10:50:12AM +0200, Stefano Sabatini wrote:
> On date Monday 2011-08-29 03:16:43 +0200, Michael Niedermayer encoded:
> > On Sun, Aug 28, 2011 at 02:49:13AM +0200, Stefano Sabatini wrote:
> > > Updated, tested against the mp=tinterlace filter, same output is
> > > issued (but mp=tinterlace has broken PTSes all set to 0), only
> > > difference is in mode 3 where tinterlace correctly set pad lines luma
> > > values to 16 rather than to 0.
> > If it supports the same syntax, same or more features and no code
> > was lost in the porting and its same speed or faster
> > then it should be ok
> Main difference from the performance point of view is that tinterlace
> calls copy_picture_fields(), I can inline it for improving
> Apart from that, vf_tinterlace.c looks more complex of the
> corresponding vf_tinterlace.c libmpcodecs code - 326 vs. 236 LOC
> (lavfi tends to be more verbose, and I added more checks and docs for
> internal functions).
> I'm going to apply the patch in a few days if I see no comments, then
> I'll remove the mp=tinterlace wrapper if there are no objections.
I think the mp filters should only be removed once mplayer switched
The issue i see is mplayers will be improved and our native ones might
rot and then its nice to still have the wraper.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel