[FFmpeg-devel] [PATCH] Fix a crash when adding many video clips to a kdenlive project:

Mikko Rapeli mikko.rapeli at iki.fi
Wed Aug 31 15:04:30 CEST 2011


On Wed, Aug 31, 2011 at 02:38:31PM +0200, Michael Niedermayer wrote:
> > -    av_opt_free(avctx);
> >      av_freep(&avctx->priv_data);
> > +    av_opt_free(avctx);
> 
> Can you explain why you think the order of these 2 functions can
> trigger a bug ?

Granted, I did not dig too deep and don't know about ffmpeg much. I thought
av_opt_free was freeing also the priv_data pointer so glibc would call
it a free of an unallocated address.

This showed up as a crash when adding new video clips to a kdenlive project
and the crash has been gone since I added this change.

> also valgrind output should help in understanding the bug

I might be able dig this up.

-Mikko


More information about the ffmpeg-devel mailing list