[FFmpeg-devel] [PATCH] libavutil: increase struct SampleFmtInfo member 'name' length to 8

[Giorgio Vazzana]

2011/12/3 Michael Niedermayer <michaelni at gmx.at>:
> On Sat, Dec 03, 2011 at 12:10:56AM +0100, Giorgio Vazzana wrote:
>> Hello,
>>
>> running 'ffmpeg -sample_fmts' I noticed there were strange characters
>> after the sample format names:
>>
>> $ffmpeg -sample_fmts
>> ffmpeg version N-35370-g1fd6924, Copyright (c) 2000-2011 the FFmpeg developers
>>   built on Dec  2 2011 22:52:51 with gcc 4.4.3
>>   configuration: --enable-gpl
>>   libavutil    51. 29. 1 / 51. 29. 1
>>   libavcodec   53. 39. 1 / 53. 39. 1
>>   libavformat  53. 24. 0 / 53. 24. 0
>>   libavdevice  53.  4. 0 / 53.  4. 0
>>   libavfilter   2. 50. 0 /  2. 50. 0
>>   libswscale    2.  1. 0 /  2.  1. 0
>>   libpostproc  51.  2. 0 / 51.  2. 0
>> name   depth
>> u8        8
>> s16      16
>> s32      32
>> flt      32
>> dbl      64
>> u8p       8
>> s16p     16
>> s32p     32
>> fltp     32
>> dblp@    64
>>
>> This patch fixes the problem. Please comment.
>
> it could be 5 instead of 8 but i see no advantage of 5 as it would
> need 8 bytes due to alignment anyway on real systems thus

Yes, I first changed it to 5, but then I thought about alignment :)

> applied, thanks

Thank you.

> [..]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I have never wished to cater to the crowd; for what I know they do not
> approve, and what they approve I do not know. -- Epicurus
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>