[FFmpeg-devel] [PATCH] Do not use ENOTSUP
nicolas.george at normalesup.org
Tue Dec 20 18:38:03 CET 2011
Thanks for the report.
Le decadi 30 frimaire, an CCXX, Rafaël Carré a écrit :
> - case CELT_UNIMPLEMENTED: return AVERROR(ENOTSUP);
> + case CELT_UNIMPLEMENTED: return AVERROR_PATCHWELCOME;
PATCHWELCOME means "Not yet implemented in FFmpeg, patches welcome", but
CELT_UNIMPLEMENTED means that the problem is in libcelt. ENOSYS would
probably be a good replacement.
> if (flags || stream_index > 0)
> - return AVERROR(ENOTSUP);
> + return AVERROR_PATCHWELCOME;
Here too, this is not something that can be fixed. EINVAL would probably
mean mostly the same thing.
I can fix it that way in my working tree, or you can send your patch again,
but I would like you tu confirm that ENOSYS would work for you before
In fact, if you have time, I would be grateful if you could send me a
complete list of the EFOOBAR codes that your build environment supports,
along with its exact name and version. Building such a list for the various
supported systems was one of my immediate projects.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel