[FFmpeg-devel] [PATCH] Do not use ENOTSUP
michaelni at gmx.at
Tue Dec 20 19:03:23 CET 2011
On Tue, Dec 20, 2011 at 06:38:03PM +0100, Nicolas George wrote:
> Thanks for the report.
> Le decadi 30 frimaire, an CCXX, Rafaël Carré a écrit :
> > - case CELT_UNIMPLEMENTED: return AVERROR(ENOTSUP);
> > + case CELT_UNIMPLEMENTED: return AVERROR_PATCHWELCOME;
> PATCHWELCOME means "Not yet implemented in FFmpeg, patches welcome", but
> CELT_UNIMPLEMENTED means that the problem is in libcelt. ENOSYS would
> probably be a good replacement.
> > if (flags || stream_index > 0)
> > - return AVERROR(ENOTSUP);
> > + return AVERROR_PATCHWELCOME;
> Here too, this is not something that can be fixed. EINVAL would probably
> mean mostly the same thing.
non zero flags should be quite fixable
> I can fix it that way in my working tree, or you can send your patch again,
> but I would like you tu confirm that ENOSYS would work for you before
> pushing anything.
ENOSYS is ok, its used all over the ffmpeg code
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel