[FFmpeg-devel] [PATCH] Port tinterlace filter from MPlayer.

Stefano Sabatini stefasab at gmail.com
Tue Dec 27 13:08:52 CET 2011


On date Tuesday 2011-08-30 10:50:12 +0200, Stefano Sabatini encoded:
> On date Monday 2011-08-29 03:16:43 +0200, Michael Niedermayer encoded:
> > On Sun, Aug 28, 2011 at 02:49:13AM +0200, Stefano Sabatini wrote:
> [...]
> > > Updated, tested against the mp=tinterlace filter, same output is
> > > issued (but mp=tinterlace has broken PTSes all set to 0), only
> > > difference is in mode 3 where tinterlace correctly set pad lines luma
> > > values to 16 rather than to 0.
> > 
> > If it supports the same syntax, same or more features and no code
> > was lost in the porting and its same speed or faster
> > then it should be ok
> 
> Main difference from the performance point of view is that tinterlace
> calls copy_picture_fields(), I can inline it for improving
> performance.
> 
> Apart from that, vf_tinterlace.c looks more complex of the
> corresponding vf_tinterlace.c libmpcodecs code - 326 vs. 236 LOC
> (lavfi tends to be more verbose, and I added more checks and docs for
> internal functions).
> 
> I'm going to apply the patch in a few days if I see no comments, then
> I'll remove the mp=tinterlace wrapper if there are no objections.
[...]

Updated with misc cosmetics for improving readability, I'll apply soon
if I read no comments.
-- 
FFmpeg = Fascinating and Forgiving Magical Pacific Evangelical God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-port-tinterlace-filter-from-MPlayer.patch
Type: text/x-diff
Size: 16963 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111227/8e868efb/attachment.bin>


More information about the ffmpeg-devel mailing list