[FFmpeg-devel] [PATCH] nobody cares: use designated initializers

Paul B Mahol onemda at gmail.com
Fri Dec 30 16:54:05 CET 2011


On 12/30/11, Clement Boesch <ubitux at gmail.com> wrote:
> On Fri, Dec 30, 2011 at 12:02:05PM +0000, Paul B Mahol wrote:
>
> I do care ;)
>
>> ---
>>  libavcodec/bintext.c          |   51
>> +++++++++++++++++++---------------------
>>  libavcodec/diracdec.c         |    1 -
>>  libavcodec/g729dec.c          |   14 +++++------
>>  libavcodec/j2kdec.c           |   15 +++++------
>>  libavcodec/j2kenc.c           |   14 +++++-----
>>  libavcodec/libaacplus.c       |   14 +++++-----
>>  libavcodec/libopenjpegenc.c   |    1 -
>>  libavcodec/libutvideo.cpp     |   22 ++++++-----------
>
> Do not do it for C++ please. Maybe add a note about this (you're not the
> first one to propose such change).

Fixed.
>
> Maybe also mention in the commit description you removed some pointless
> NULL assignments.

Done.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-forgotten-use-designated-initializers.patch
Type: application/octet-stream
Size: 18406 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111230/03411503/attachment.obj>


More information about the ffmpeg-devel mailing list