[FFmpeg-devel] [PATCH] Implement AAC Long Term Prediction (LTP) decoding module

Måns Rullgård mans
Tue Feb 1 13:50:42 CET 2011

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Feb 01, 2011 at 10:57:28AM +0900, Young Han Lee wrote:
>> please check it again. :)
> Looks good now.  Some more nits for your Doxygen comments below, but
> don't bother sending a new patch.  Wait for the review from Alex first.
>> --- a/libavcodec/aacdec.c
>> +++ b/libavcodec/aacdec.c
>> @@ -1682,23 +1706,108 @@ static void apply_tns(float coef[1024], TemporalNoiseShaping *tns,
>> +/**
>> + * Windowing and MDCT to obtain the spectral coefficient from the predicted sample by LTP
> This is a longish line that you could break and end in a period.
> The sentence would also be easier to understand if there was a
> verb in it.

"Obtain" is a verb.  Agree about the line length.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list