[FFmpeg-devel] [PATCH 1/4] TCP: factor the poll() call

Måns Rullgård mans
Wed Feb 2 20:14:38 CET 2011

Nicolas George <nicolas.george at normalesup.org> writes:

> Le quartidi 14 pluvi?se, an CCXIX, M?ns Rullg?rd a ?crit?:
>> > +static int tcp_wait_fd(int fd, int write)
>> Is there a reason you don't let the caller simply pass POLLIN or
>> POLLOUT directly?
> I wrote tcp_wait_fd when the code was still using select, but the change to
> poll was an idea floating around. Using this method limited the places where
> it needed to be changed, and will limit it also if for whatever reason it
> must be changed from poll to something else.

Good point, keep it that way.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list