[FFmpeg-devel] [PATCH 0/6] libavformat: Simplify muxer cleanup and chained muxers

Martin Storsjö martin
Thu Feb 3 13:10:11 CET 2011


This patch series sorts out a few issues around freeing muxers.
Patches #3 and #4 are the most interesting ones that I'd want
an authoritive comment on.

Quick comment on the patches:
#1: Non-controversial, yet another leak in the same style as the
    ones I fixed yesterday.
#2: Only touches code I maintain myself. If someone else uses the
    RTSP muxer, I'd appreciate testing to see that it doesn't break
    any setup.
#3: Adding a new public function, please comment
#4: Using the function from #3, should be straightforward
#5: Code I maintain myself. Please test if you use the RTSP muxer.
#6: Code I maintain myself, simplification. Test if you use the
    RTP hinting in the mov muxer, otherwise you can take my word
    for it.

Martin Storsj? (6):
  sapenc: Free AVStream->info on cleanup
  libavformat: Use avcodec_copy_context for chained muxers
  libavformat: Add a function for freeing an AVFormatContext
  Use av_free_context for freeing muxers
  rtpenc_chain: Don't copy the time_base back to the caller
  movenchint: Use rtpenc_chain for setting up the chained RTP muxer

 ffmpeg.c                   |   16 +-------------
 libavformat/Makefile       |    3 +-
 libavformat/avformat.h     |    6 +++++
 libavformat/movenchint.c   |   50 +++----------------------------------------
 libavformat/rtpenc_chain.c |   12 +--------
 libavformat/rtsp.c         |    6 +----
 libavformat/sapenc.c       |    5 +---
 libavformat/utils.c        |   11 +++++++--
 8 files changed, 25 insertions(+), 84 deletions(-)


More information about the ffmpeg-devel mailing list