[FFmpeg-devel] Compromise

[Luca Barbato]

On 02/05/2011 01:17 AM, Baptiste Coudurier wrote:
> On 02/04/2011 03:08 PM, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Fri, Feb 4, 2011 at 3:52 AM, Nicolas George
>> <nicolas.george at normalesup.org>  wrote:
>>> It would be nice if each one of the commiters could take time to answer,
>>> point by point, to these conditions and tell if he thinks them
>>> acceptable,
>>> and if not, why.
>>
>> Disclaimer: I only speak for myself.
>>
>>>>> roots replaced by neutral people
>>
>> Unacceptable. I think they do a good job. You can't scapegoat the
>> roots for what happened.
> 
> Why is this unacceptable ? IMHO doing a good job is necessary but not
> enough.

Making scapegoat out of people is unacceptable.

>> Stefano: that has come up before, Stefano's work may benefit from
>> being in a separate topic branch.
>> Michael: I see too much hostility to consider that an option, for now.
>>
>>>>> clarification of leadership of new team
>>
>> I commit patches. I'm not an expert in every field but try to be
>> helpful in reviews and depend on experts in particular fields to tell
>> me what's right. I take responsibility for the patches that I commit,
>> and I feel responsible for making sure that FFmpeg as a project floats
>> in a direction that I feel is good for the project.
> 
> I though committing was only a burden ?

it is.

> From what you say, this definitely has a huge impact on what goes in and
> what does not goes in.

If somebody is unconfortable ask somebody else to do that. E.g. Janne
with Martin patches. I did signoff them instead of him since he wanted
me to doublecheck.

> If you do not agree but a maintainer agrees with the patch, the patch
> _must_ go in whether you agree or not. This is why, IMHO you should not
> feel responsible for the patches you apply.

If somebody is unsure ask to somebody else. I think isn't bad as
reasoning and as effect.

> Ideally, the codereview tool should apply the patches itself once they
> pass compilation and fate and/or regression suite.

Couldn't set up one that would burden us a lot, let's first get used to
git and the current situation, then we could improve over it.

> I don't think that is true, and you know why, but let's not start
> another flamewar.

Thank you =)

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero