[FFmpeg-devel] [PATCH 3/3] Non-blocking protocol: TCP

Ronald S. Bultje rsbultje
Sun Feb 6 02:42:10 CET 2011


On Sat, Feb 5, 2011 at 8:32 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Fri, Feb 4, 2011 at 1:12 PM, Nicolas George
> <nicolas.george at normalesup.org> wrote:
>> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
>> ---
>> ?libavformat/tcp.c | ? 47 +++++++++++------------------------------------
>> ?1 files changed, 11 insertions(+), 36 deletions(-)
> Queued this and the other ones for tomorrow.
> Question: udp.c is still a mess, could you consider cleaning that up also?

Also, I know this has nothing to do with before your patch, but a
quick grep shows:
libavformat/rtsp.c:                        ret =
url_read(rtsp_st->rtp_handle, buf, buf_size);
libavformat/rtsp.c:        ret = url_read(in, recvbuf, sizeof(recvbuf));
libavformat/sapdec.c:        ret = url_read(sap->ann_fd, recvbuf,
sizeof(recvbuf) - 1);
libavformat/sapdec.c:        ret = url_read(sap->ann_fd, recvbuf,

These seem ... questionable, and might need review. Particularly the
one in the RTP punching code in rtsp.c is questionable and looks
unsafe/wrong. Is anyone interested in fixing these up and moving them
up to url_read_complete() or otherwise making sure they are safe?


More information about the ffmpeg-devel mailing list