[FFmpeg-devel] [PATCH 2/4] lavf: add avio_ prefix to get* functions

[Ronald S. Bultje]

Hi,

On Sun, Feb 6, 2011 at 8:13 AM, Anton Khirnov <anton at khirnov.net> wrote:
> diff --git a/libavformat/avio.h b/libavformat/avio.h
> index 4ea493c..99acfe0 100644
> --- a/libavformat/avio.h
> +++ b/libavformat/avio.h
> @@ -370,6 +370,18 @@ attribute_deprecated void put_be24(ByteIOContext *s, unsigned int val);
> ?attribute_deprecated void put_le16(ByteIOContext *s, unsigned int val);
> ?attribute_deprecated void put_be16(ByteIOContext *s, unsigned int val);
> ?attribute_deprecated void put_tag(ByteIOContext *s, const char *tag);
> +
> +attribute_deprecated int ? ? ? ? ?get_buffer(ByteIOContext *s, unsigned char *buf, int size);
> +attribute_deprecated int ? ? ? ? ?get_partial_buffer(ByteIOContext *s, unsigned char *buf, int size);
> +attribute_deprecated int ? ? ? ? ?get_byte(ByteIOContext *s);
> +attribute_deprecated unsigned int get_le16(ByteIOContext *s);
> +attribute_deprecated unsigned int get_le24(ByteIOContext *s);
> +attribute_deprecated unsigned int get_le32(ByteIOContext *s);
> +attribute_deprecated uint64_t ? ? get_le64(ByteIOContext *s);
> +attribute_deprecated unsigned int get_be16(ByteIOContext *s);
> +attribute_deprecated unsigned int get_be24(ByteIOContext *s);
> +attribute_deprecated unsigned int get_be32(ByteIOContext *s);
> +attribute_deprecated uint64_t ? ? get_be64(ByteIOContext *s);
> ?#endif
>
> ?void avio_put_byte( ?ByteIOContext *s, int b);

I wonder if some doxy here would be useful, e.g.

/**
 * @defgroup old_avio_funcs Old put_/get_*() functions
 * @deprecated use their avio_put/get_*() counterpart instead
 * @{
 */
all deprecated function declarations
/**
 * @}
 */

And then hopefully, doxygen will do the right thing and tell you not
to use these functions in addition to them being deprecated.

In general I like these patches, I'll wait a few days for comments
from others and then queue 'em up here, unless others beat me to it.

Ronald