[FFmpeg-devel] [PATCH 11/11] Make inter_rvlc and intra_rvlc static tables.

Ronald S. Bultje rsbultje
Sun Feb 6 15:54:21 CET 2011


On Sun, Feb 6, 2011 at 9:47 AM, Diego Elio Petten? <flameeyes at gmail.com> wrote:
> Il giorno mar, 25/01/2011 alle 10.53 -0500, Ronald S. Bultje ha scritto:
>> Doesn't this duplicate the tables in each file? Please extern them and
>> then define them in a .c file instead.
> Fun times ahead! Your grep was reporting not "mpeg4data.h" but
> "msmpeg4data.h" as well:

Oh, right, ok, patch is fine then.

> I guess another alternative would be to move the whole definition of
> those two tables into mpeg4videodec.c so that they are fully static
> there.

Nah, we always put tables in .h files. Keeps .c files nice and clean.


More information about the ffmpeg-devel mailing list