[FFmpeg-devel] [PATCH] Make av_set_pts_info keep previous time base if new one is invalid.

Michael Niedermayer michaelni
Sun Feb 6 16:05:48 CET 2011

On Sun, Feb 06, 2011 at 03:20:37PM +0100, Reimar D?ffinger wrote:
> On Sun, Feb 06, 2011 at 02:36:28PM +0100, Michael Niedermayer wrote:
> > On Sun, Feb 06, 2011 at 11:37:52AM +0100, Reimar D?ffinger wrote:
> > > Can be done, even though I'd like to note that I don't see why it has
> > > to be in one patch, the things you mention were an issue before,
> > > this fixes just one issue: setting values that make the rest of
> > > the code crash.
> > 
> > I never said it has to be in one patch.
> I'm really not in the mood for these crappy reviews.

what is it that ive now said to upset you?

> Is the patch ok or not, if not what is the minium you want for it
> to be ok?

not ok because it turns a crash that is easy to debug into a uninitilaized
value without error message which can be timeconsuming to debug
Printing a warning makes it ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110206/ed253cb0/attachment.pgp>

More information about the ffmpeg-devel mailing list