[FFmpeg-devel] [PATCH] pass QDMC extradata to the decoder

[Baptiste Coudurier]

On 02/06/2011 01:07 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Sun, Feb 6, 2011 at 8:25 AM, Michael Niedermayer<michaelni at gmx.at>  wrote:
>> On Sun, Feb 06, 2011 at 01:54:03PM +0100, Sascha Sommer wrote:
>>> Hi,
>>>
>>> I noticed that playing QDMC files does not work in MPlayer when the
>>> libavformat demuxer is used.
>>>
>>> One part of the problem seems to be that the extradata is not passed to the
>>> binary decoder like it is done for QDM2.
>>>
>>> Attached patch fixes this problem.
>>>
>>> Regards
>>>
>>> Sascha
>>>
>>>
>>
>>>   libavcodec/avcodec.h |    1 +
>>>   libavformat/isom.c   |    1 +
>>>   libavformat/mov.c    |    4 ++--
>>>   3 files changed, 4 insertions(+), 2 deletions(-)
>>> 3ef8a30901d3849deec2e4cec5e1b09d4c9eff57  qdmc.patch
>>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>> index dbfb777..fc29bba 100644
>>> --- a/libavcodec/avcodec.h
>>> +++ b/libavcodec/avcodec.h
>>> @@ -389,6 +389,7 @@ enum CodecID {
>>>       CODEC_ID_BINKAUDIO_RDFT,
>>>       CODEC_ID_BINKAUDIO_DCT,
>>>       CODEC_ID_AAC_LATM,
>>> +    CODEC_ID_QDMC,
>>>
>>>       /* subtitle codecs */
>>>       CODEC_ID_DVD_SUBTITLE= 0x17000,
>>
>> ok, rest is for baptiste to review
>
> Queued for now, looks rather straightforward. Baptiste, please object
> if there's a reason not to apply this. Otherwise will apply tomorrow.
>

Good to go.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org