[FFmpeg-devel] [PATCH] CrystalHD decoder support v4

Philip Langdale philipl
Mon Feb 7 00:56:36 CET 2011


 Hi all,

 Here is the updated CrystalHD patch reflecting all feedback given to 
 v3.

 Major changes
 -------------

 * Uses the mp4toannexb bsf to convert the extradata. This removes the 
 dependency
   on broadcom code and renders the licence mismatch moot.

 * Discarded the elaborate input_full handling. With the pipline no 
 longer growing
   out of control, input_full will never happen, so it's simpler to just 
 return that
   we didn't consume any bytes and move on with life.

 * Uses pkt_pts instead of reordered_opaque now that ffmpeg/ffplay have 
 been switched
   over (in both upstreams).

 Outstanding issues
 ------------------

 No change here except that the licensing issue is now resolved.

 I've done more 70012 testing and it's actually usable now. I need to 
 tweak the
 picture_number continuity test - the last sample I worked with had a 
 discontinuity
 on 70012 and not on 70015. At this point, I'm not convinced that a 
 discontinuity
 is actually significant in any way.

 Punchline
 ---------

 I think it's now possible to seriously consider this for acceptance. 
 Yes, there are
 unresolved problems with 70012 and interlaced handling, but the core 
 functionality is
 sound and genuinely useful. The remaining problems can be addressed 
 incrementally.

 Thanks,

 --phil

-- 
 --phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crystalhd-v4.diff
Type: text/x-diff
Size: 35807 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110206/378a15c4/attachment.diff>



More information about the ffmpeg-devel mailing list