[FFmpeg-devel] [PATCH] Fix broken vbv_buffer_init handling in libx264.c

Baptiste Coudurier baptiste.coudurier
Mon Feb 7 11:22:32 CET 2011

On 2/7/11 2:18 AM, Jason Garrett-Glaser wrote:
> On Mon, Feb 7, 2011 at 1:42 AM, Baptiste Coudurier
> <baptiste.coudurier at gmail.com> wrote:
>> On 2/6/11 5:11 AM, Jason Garrett-Glaser wrote:
>>> Due to being pants-on-head retarded, libavcodec defaults this to zero, which
>>> results in broken output.
>> x264_encoder_open should fail instead of silently generating a broken
>> output.
> What values should it fail for?  0 is clearly bad, but what about
> 0.001?  Where do you place the cutoff?

You're the one knowing when the code breaks. Check when it fails and
return an error.

Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list