[FFmpeg-devel] [PATCH 2/2] Add sample_aspect_ratio fields to vsrc_buffer arguments. This fixes aspect handling in ffmpeg This is based on a patch by baptiste

Stefano Sabatini stefano.sabatini-lala
Mon Feb 7 11:37:43 CET 2011

On date Sunday 2011-02-06 16:17:59 +0100, Michael Niedermayer encoded:
> On Sun, Feb 06, 2011 at 04:03:56PM +0100, Stefano Sabatini wrote:
> > On date Sunday 2011-02-06 00:26:17 +0100, Michael Niedermayer encoded:
> > > dont forget to test that your cases get aspects both on init time as well as
> > > per frame time correct
> > 
> > I don't think this was never supported, so I'd rather skip it for now
> > (which should be addressed by filtegraph dynamic reconfiguration).
> it works in ffmpeg at videolan except for the stream copy case where one of the
> 2 is wrong but it was wrong before libavfilter there too according to my tests.
> And yes i do test before pushing changes
> If you send patches against videolan i can help you think about how to fix the
> remaining issues there. But with patches against ffmpeg.org its less work for
> me to fix it myself in videolan and ignore what is submitted here because you
> work on a basis that is much buggier and these are bugs ive fixed already.

So I suggest to apply the patches as committed to ffmpeg at videolan, and
from there fix both repos at the same time, having to fix one single
codebase is enough for me.
FFmpeg = Furious Foolish Merciful Programmable Encoding/decoding Gadget

More information about the ffmpeg-devel mailing list