[FFmpeg-devel] [PATCH 1/2] cmdutils: fix opt_values leak
Frans de Boer
Tue Feb 8 02:50:28 CET 2011
On 02/08/2011 02:36 AM, Ronald S. Bultje wrote:
> On Mon, Feb 7, 2011 at 6:43 PM, James Zern<jzern at google.com> wrote:
>> On Sat, Feb 5, 2011 at 14:20, Ronald S. Bultje<rsbultje at gmail.com> wrote:
>>> On Fri, Feb 4, 2011 at 8:58 PM, James Zern<jzern at google.com> wrote:
>>>> Add free to uninit_opts and relocate opt_names to same
>>>> cmdutils.c | 2 ++
>>>> ffmpeg.c | 1 -
>>>> 2 files changed, 2 insertions(+), 1 deletions(-)
>>>> In addition to this it is possible that opt_names could be removed
>>>> from cmdutils.h as it's unused elsewhere.
>>> Looks OK to me, queued locally. You could also consider making
>>> opt_names and opt_values (and possibly others) static if you
>>> remove them from cmdutils.h.
>> Yes I thought I'd check on the opinion of that before making that
>> change as the remainder of the set is still exposed (sws, avformat,
>> etc.), though those are used.
> It's fine with me to make it static. Michael, objections?
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
Sorry this I can not understand. @Ronald: a few emails ago you stated to
have no contact with Micheal for some time. Today you ask for his approval?
What will it be: part of the coup members or part of the community members?
Maybe I have missed something, but I am just very puzzled right now.
Hope for a good response on this list.
More information about the ffmpeg-devel