[FFmpeg-devel] [PATCH] spdifenc: IEC 61937 encapsulation of DTS-HD for HDMI

Anssi Hannula anssi.hannula
Fri Feb 11 03:43:02 CET 2011


On 10.02.2011 23:39, Justin Ruggles wrote:
> On 02/10/2011 04:03 PM, Janne Grunau wrote:
> 
>> On Sat, Jan 29, 2011 at 03:36:30AM +0200, Anssi Hannula wrote:
>>> ---
>>>
>>> Here's this patch again, modified for Justin's comments and rebased to
>>> master (and tested it is still working).
>>>
>>> Justin Ruggles wrote:
>>>> I see quite a few "sizeof(dtshd_start_code) + 2 + pkt_size".  Could
>>>> these be factored out?
>>>
>>> Actually, there were only 3 and the value of pkt_size may be different
>>> for the first one. I now got rid of one by rearranging the lines a
>>> little.
>>>
>>>  Changelog              |    2 +-
>>>  libavformat/spdifenc.c |  148 ++++++++++++++++++++++++++++++++++++++++++++++++
>>>  libavformat/version.h  |    2 +-
>>>  3 files changed, 150 insertions(+), 2 deletions(-)
>>
>> lgtm, Justin, further comments?
> 
> 
> It would be nice to have a new entry to muxers.texi to show the options,
> but that shouldn't hold up commit.  Everything else looks fine to me.

OK, I'll write something there after these patches are applied :)

-- 
Anssi Hannula



More information about the ffmpeg-devel mailing list