[FFmpeg-devel] [PATCH] Fix qtrle regression test, actually test qtrle.

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at gmail.com> writes:

> ---
>  tests/codec-regression.sh |    4 ++--
>  tests/ref/vsynth1/qtrle   |    8 ++++----
>  tests/ref/vsynth2/qtrle   |    8 ++++----
>  3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tests/codec-regression.sh b/tests/codec-regression.sh
> index b0a8423..34911d5 100755
> --- a/tests/codec-regression.sh
> +++ b/tests/codec-regression.sh
> @@ -249,8 +249,8 @@ do_video_decoding "" "-pix_fmt yuv420p"
>  fi
>
>  if [ -n "$do_qtrle" ] ; then
> -do_video_encoding qtrle.mov "" ""
> -do_video_decoding "" ""
> +do_video_encoding qtrle.mov "" "-an -vcodec qtrle"
> +do_video_decoding "" "-pix_fmt yuv420p"
>  fi
>
>  if [ -n "$do_rgb" ] ; then
> diff --git a/tests/ref/vsynth1/qtrle b/tests/ref/vsynth1/qtrle
> index 8aa578f..9988897 100644
> --- a/tests/ref/vsynth1/qtrle
> +++ b/tests/ref/vsynth1/qtrle
> @@ -1,4 +1,4 @@
> -3f070779d7deb54626515ac7f7002e63 *./tests/data/vsynth1/qtrle.mov
> -387772 ./tests/data/vsynth1/qtrle.mov
> -a3c2610e2c069c3ad22ec03da83f774f *./tests/data/qtrle.vsynth1.out.yuv
> -stddev:   15.14 PSNR: 24.53 MAXDIFF:  174 bytes:  7603200/  7603200
> +d14041925ce5ec5001dc519276b1a1ab *./tests/data/vsynth1/qtrle.mov
> +15263232 ./tests/data/vsynth1/qtrle.mov
> +243325fb2cae1a9245efd49aff936327 *./tests/data/qtrle.vsynth1.out.yuv
> +stddev:    3.42 PSNR: 37.43 MAXDIFF:   48 bytes:  7603200/  7603200
> diff --git a/tests/ref/vsynth2/qtrle b/tests/ref/vsynth2/qtrle
> index 756ed69..6b2a011 100644
> --- a/tests/ref/vsynth2/qtrle
> +++ b/tests/ref/vsynth2/qtrle
> @@ -1,4 +1,4 @@
> -5346bba8e03e7de72b482efbcf712a2e *./tests/data/vsynth2/qtrle.mov
> -141533 ./tests/data/vsynth2/qtrle.mov
> -f967b290c7e6d015c0e78175db828249 *./tests/data/qtrle.vsynth2.out.yuv
> -stddev:    5.75 PSNR: 32.93 MAXDIFF:   92 bytes:  7603200/  7603200
> +d8c1604dc46d9aa4ec0385e6722c6989 *./tests/data/vsynth2/qtrle.mov
> +14798419 ./tests/data/vsynth2/qtrle.mov
> +b2418e0e3a9a8619b31219cbcf24dc82 *./tests/data/qtrle.vsynth2.out.yuv
> +stddev:    1.26 PSNR: 46.06 MAXDIFF:   13 bytes:  7603200/  7603200
> -- 

At some point we should test this and other rgb codecs in their native
pixel format, e.g. by converting the test video first.  In the meantime,
this is unquestionably an improvement.  Pushing.

-- 
M?ns Rullg?rd
mans at mansr.com