[FFmpeg-devel] [PATCH] configure: fix non-standard regex used with expr

Ronald S. Bultje rsbultje
Sun Feb 13 22:41:08 CET 2011


Hi,

On Sun, Feb 13, 2011 at 4:12 PM, Mans Rullgard <mans at mansr.com> wrote:
> The colon operator of expr always anchors the pattern at the start
> of the string. ?An explicit ^ in the pattern has unspecified
> behaviour, so remove it.
>
> Signed-off-by: Mans Rullgard <mans at mansr.com>
> ---
> ?configure | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 8cf6d4c..90eeaa0 100755
> --- a/configure
> +++ b/configure
> @@ -1867,7 +1867,7 @@ elif $cc -v 2>&1 | grep -qi ^gcc; then
> ? ? cc_version=__VERSION__
> ? ? gcc_version=$($cc --version | head -n1)
> ? ? gcc_basever=$($cc -dumpversion)
> - ? ?gcc_pkg_ver=$(expr "$gcc_version" : '^[^ ]* \(([^)]*)\)')
> + ? ?gcc_pkg_ver=$(expr "$gcc_version" : '[^ ]* \(([^)]*)\)')
> ? ? gcc_ext_ver=$(expr "$gcc_version" : ".*$gcc_pkg_ver $gcc_basever \\(.*\\)")
> ? ? cc_ident=$(cleanws "gcc $gcc_basever $gcc_pkg_ver $gcc_ext_ver")
> ? ? if ! $cc -dumpversion | grep -q '^2\.'; then
> --
> 1.7.4

OK.

Ronald



More information about the ffmpeg-devel mailing list