[FFmpeg-devel] [PATCH] fix nsvdec.c compilation if DEBUG macro defined
Tue Feb 15 19:36:55 CET 2011
looks like I'm still officially maintainer for this...
Le 15 f?vr. 2011 ? 15:14, Ronald S. Bultje a ?crit :
> On Tue, Feb 15, 2011 at 8:42 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> On Tue, Feb 15, 2011 at 6:58 AM, Maksym Veremeyenko <verem at m1stereo.tv> wrote:
>>> @@ -623,7 +612,7 @@ null_chunk_retry:
>>> pkt->flags |= nsv->state == NSV_HAS_READ_NSVS ? AV_PKT_FLAG_KEY : 0; /* keyframe only likely on a sync frame */
>>> for (i = 0; i < MIN(8, vsize); i++)
>>> - PRINT(("NSV video: [%d] = %02x\n", i, pkt->data[i]));
>>> + av_dlog(s, "NSV video: [%d] = %02x\n", i, pkt->data[i]);
>> gcc is smart enough to remove the loop, so the /* and */ are unnecessary.
> Also, MIN -> FFMIN. :-).
It would indeed need some more cleanup (it's probably buried in my TODO list), but I wouldn't mind committing the av_log patch first.
More information about the ffmpeg-devel