[FFmpeg-devel] About guess_correct_pts / AVFrame.best_effort_timestamp
Wed Feb 16 16:34:37 CET 2011
L'octidi 28 pluvi?se, an CCXIX, Luca Barbato a ?crit?:
> Transcoding results in a foo.mp4 with the correct timing? (shouldn't)
./ffmpeg -i hellsing-h264-blocking.mkv t.mp4
pts_time=0.000000 dts_time=0.000000 (time_base = 1/24000)
while the original had:
pts_time=0.000000 dts_time=0.000000 (time_base = 1/1000)
I think these timestamps are completely valid.
> I think we are hitting two different orthogonal issues here...
I think so too.
> With the same bad inputs as trigger the error you see in copy mode.
And with the same bad inputs, it manages to produce good output.
> The topic of the thread is timestamps. Your patch does not fix any
> existing problem in the timestamp handling.
This is not the purpose of my patch. The purpose of my patch is to
introduce, as part of the API, a single, preferred timestamp for the decoded
> All it does is make some
> broken guesswork part of the API.
Not part of the API, part of the logic behind the API.
If the algorithm is broken, *which you still have to prove*, it can be
changed, but this is an different issue.
> On those grounds, the patch is
As you are not project leader nor file maintainer, you are not entitled to
reject anything. You can only convince other people here that you are right,
and you still need to give technical evidence for that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel