[FFmpeg-devel] [PATCH] Try to fix issue 1973

Michael Niedermayer michaelni
Fri Feb 18 13:31:05 CET 2011

On Fri, Feb 18, 2011 at 10:52:07AM +0100, Jean-Daniel Dupas wrote:
> Hello
> I would like to try to resubmit an old patch that try to fix a buffer overrun in the targa decoder.
> It was rejected long ago after endless discussion about  white space and formatting.

yes, it was rejected by mans
heres the last mail in the thread (written by you)
iam just quoting that here before people start claiming i rejected it
1-2 members of the new team like to use these kind of lies, most of them
are luckily quite nice people. Kostya even approved the patch, both back then
as well as now, which i support too.

Le 31 mai 2010 ? 12:15, M?ns Rullg?rd a ?crit :

> Kostya <kostya.shishkov at gmail.com> writes:
>> On Sun, May 30, 2010 at 08:51:00PM +0200, Jean-Daniel Dupas wrote:
>>> Le 30 mai 2010 ? 20:34, Kostya a ?crit :
>>>> On Sun, May 30, 2010 at 07:29:03PM +0200, Jean-Daniel Dupas wrote:
>>>> [...]
>>>>>> Still there is weird indentation of two spaces on some lines. And in
>>>>>> your check macro "return -1" is missing 4 spaces on indent.
>>>>> Sorry for that. This time I hope it's good.
>>>> Still wrong in check for image size. But you're almost there.
>>> Argh, another try. It's hard to go against the habits. I'm used to
>>> 2 spaces ;-) .
>> Please remove spaces between if (x) {, now it's inconsitent in your
>> patch (you have "if (x) {", "if(x) {" and "if(x){", I want the latter
>> and the same for "else" clause). After that it should be totally OK.
> Usual FFmpeg style is "if (x) {".

targa.c already uses "if(x){", so at least, this patch is now consistent with the targa.c file.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110218/f4e101cd/attachment.pgp>

More information about the ffmpeg-devel mailing list