[FFmpeg-devel] [PATCH 1/5] bink: set audio stream codec_tag such that binkaudio decoder can identify bitstream version

[Peter Ross]

On Sat, Feb 19, 2011 at 07:13:31PM -0700, Daniel Verkamp wrote:
> On Sat, Feb 19, 2011 at 6:24 PM, Peter Ross <pross at xvid.org> wrote:
> > ---
> > ?libavformat/bink.c | ? ?2 +-
> > ?1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/libavformat/bink.c b/libavformat/bink.c
> > index dfad6c2..875c1f8 100644
> > --- a/libavformat/bink.c
> > +++ b/libavformat/bink.c
> > @@ -134,7 +134,7 @@ static int read_header(AVFormatContext *s, AVFormatParameters *ap)
> > ? ? ? ? ? ? if (!ast)
> > ? ? ? ? ? ? ? ? return AVERROR(ENOMEM);
> > ? ? ? ? ? ? ast->codec->codec_type ?= AVMEDIA_TYPE_AUDIO;
> > - ? ? ? ? ? ?ast->codec->codec_tag ? = 0;
> > + ? ? ? ? ? ?ast->codec->codec_tag ? = vst->codec->codec_tag;
> > ? ? ? ? ? ? ast->codec->sample_rate = get_le16(pb);
> > ? ? ? ? ? ? av_set_pts_info(ast, 64, 1, ast->codec->sample_rate);
> > ? ? ? ? ? ? flags = get_le16(pb);
> > --
> > 1.7.1
> >
> 
> Maybe this should get its own codec id? Either way, overall series
> looks good to me.

Using tags to identify the different versions is in keeping with the
way its done for Bink video.

The b version is only so sightly different from the f,g,h,i versions.

Cheers,

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110220/8ab7a897/attachment.pgp>