[FFmpeg-devel] [PATCH] avio: Check for FF_NETERROR(EAGAIN) in retry_transfer_wrapper

Martin Storsjö martin
Tue Feb 22 14:35:30 CET 2011


On Tue, 22 Feb 2011, Ronald S. Bultje wrote:

> On Tue, Feb 22, 2011 at 8:06 AM, Martin Storsj? <martin at martin.st> wrote:
> > On Tue, 22 Feb 2011, Ronald S. Bultje wrote:
> >
> >> On Tue, Feb 22, 2011 at 3:15 AM, Martin Storsj? <martin at martin.st> wrote:
> >> > On Mon, 21 Feb 2011, Nicolas George wrote:
> >> >
> >> >> Le tridi 3 vent?se, an CCXIX, Ronald S. Bultje a ?crit?:
> >> >> > Can we map them to self-defined error codes on Windows? Made-up
> >> >> > values, is what I mean.
> >> >>
> >> >> What about using the same values as currently, on a case-by-case basis:
> >> >>
> >> >> #ifndef ECONNREFUSED
> >> >> #define ECONNREFUSED WSAECONNREFUSED
> >> >> #endif
> >> >>
> >> >> ?
> >> >
> >> > That might be a good idea, but I'm not totally convinced. Do we want this
> >> > in libavutil/error.h, or internally within lavf somewhere?
> >>
> >> Internally, for now at least, definitely. I realize that error
> >> reporting will be an issue to calling applications, but we'll have to
> >> live with that. Let's be honest, half of our functions return simply
> >> -1 anyway.
> >
> > Ok, new patch attached that achieves this, getting rid of FF_NETERRNO()
> > completely.
> 
> Looks good to me.
> 
> > +#define EPROTONOSUPPORT WSAEPROTONOSUPPORT
> > +#define ETIMEDOUT WSAETIMEDOUT
> > +#define ECONNREFUSED WSAECONNREFUSED
> > +#define EINPROGRESS WSAEINPROGRESS
> 
> Can you confirm that AVERROR(thesethingies) returns something negative?

Yes, both normal errno.h constants and WSAE* have positive values on 
windows.

// Martin



More information about the ffmpeg-devel mailing list