[FFmpeg-devel] [PATCH 01/16] vmdaudio: fix raw_block_size calculation.

[Reimar Döffinger]

On Tue, Feb 22, 2011 at 08:26:59PM +0100, Michael Niedermayer wrote:
> On Tue, Feb 22, 2011 at 08:21:20PM +0100, Reimar D?ffinger wrote:
> > On Tue, Feb 22, 2011 at 02:05:20PM -0500, Justin Ruggles wrote:
> > > -        int raw_block_size = s->block_align * s->bits / 8;
> > > +        int raw_block_size = s->block_align *
> > > +                             (av_get_bits_per_sample_fmt(avctx->sample_fmt) / 8);
> > 
> > WTF is "bits per sample format"? That function really has a braindead name.
> 
> The number of bits in the given sample format, like 16 for SAMPLE_FMT_S16:

Yes, I know that, but the function name is "bits per sample format",
and that makes no sense. There's bits per sample, but not per sample format.