[FFmpeg-devel] [PATCH] Avoid suppressing parse errors in matroska

Ami Fischman fischman
Fri Feb 25 00:04:26 CET 2011

[apologies for the botched quote; I wasn't on the list until now and
didn't receive a direct copy of your response]
Reimar D?ffinger wrote:
> Neither loop nor crash is reproducible here.

I configured with:
./configure --disable-doc --enable-shared --enable-libvorbis
--enable-libtheora --enable-libmp3lame --enable-libvpx
--disable-decoder=vp8 --disable-bsf=mpeg4video_es
--enable-runtime-cpudetect --enable-memalign-hack
(flags pointing at the libvpx checked into the chromium tree)

> Your patch seems likely to make the demuxer handle broken
> files worse.

Can you say more about this?  What scenario do you see becoming worse?
Also, can you tell me how parse errors are meant to be handled before my patch?
AFAICT they get silently swallowed by matroska_parse_{block,cluster},
and again by av_find_stream_info.

> Also I cannot see anything that would cause an endless loop
> (though admittedly I think it might progress through a file
> very slowly).

The loop behavior just showed the ffplay time counter increasing
(quickly), but it didn't stop even though the file in question is
quite small.  What behavior do you see with "ffplay arith.webm" at


More information about the ffmpeg-devel mailing list