[FFmpeg-devel] [PATCH] configure: add check for pkg-config return value
Mon Feb 28 22:51:02 CET 2011
V?ctor Paesa <victorpaesa at googlemail.com> writes:
> On Mon, Feb 28, 2011 at 12:02, Stefano Sabatini wrote:
>> On date Thursday 2011-02-24 22:36:27 +0000, M?ns Rullg?rd encoded:
>>> Stefano Sabatini writes:
>>> > Add check_pkgconfig_flags() function. This ensures that the result of
>>> > pkg-config is correct. Avoid spurious success during configuration,
>>> > which may lead to compilation errors.
>>> > In particular prevents the compilation error I was getting with
>>> > --enable-librtmp --enable-libopencv, which was due to a missing
>>> > libssl.
>>> > ---
>>> > ?configure | ? 15 +++++++++++----
>>> > ?1 files changed, 11 insertions(+), 4 deletions(-)
>>> This is more convoluted than it needs to be. ?I'd also like to know
>>> exactly why the link test didn't fail for you before adding workarounds.
>> Simplified and updated.
>> Note: I'm not sure /dev/null is portable (what about MinGW/CygWin?).
> Works for Cygwin.
> MinGW builds use MSys that is a disguised old Cygwin.
> Maybe OS/2 needs a redirection to "nul:"
We already use >/dev/null in hundreds of places. One more isn't going
to break anything.
mans at mansr.com
More information about the ffmpeg-devel