[FFmpeg-devel] [PATCH] fix for roundup issue 2127
Sat Jan 1 17:15:50 CET 2011
On 1 jan 2011, at 01:47, Daniel Kang <daniel.d.kang at gmail.com> wrote:
> I have added the changes and ran some more tests. It passes "make fate"
> on 32/64-bit, with/without --disable-optimizations. The speed is the
> exact same as the original. Are there any comments on the updated patch?
Besides avoiding to top-post, the two strides should probably be marked early-clobber (&), I can't see why they are in the clobber list, and I also don't see why you add casts to the function calls. Well, for the last one there is at least no point _currently_, we should add casts just because it is possible to change the type so you need them, because in that case a lot of code needs to be reviewed very closely anyway.
More information about the ffmpeg-devel