[FFmpeg-devel] [PATCH] fix for roundup issue 2127

Reimar Döffinger Reimar.Doeffinger
Sat Jan 1 20:21:33 CET 2011

On 1 jan 2011, at 19:33, Daniel Kang <daniel.d.kang at gmail.com> wrote:

> On Sat, Jan 1, 2011 at 11:15 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de>wrote:
>> Besides avoiding to top-post, the two strides should probably be marked
>> early-clobber (&), I can't see why they are in the clobber list, and I also
>> don't see why you add casts to the function calls. Well, for the last one
>> there is at least no point _currently_, we should add casts just because it
>> is possible to change the type so you need them, because in that case a lot
>> of code needs to be reviewed very closely anyway.
> Sorry for the top posting. This is my first time using a mailing list.

No problem, I was just a bit surprised because you did it "right" before I think...

> I cast to x86_reg because addressing does not work in 64-bit otherwise.
> I get the errors:

I understand that you need to change the type of the function parameters, but if you also need to cast the function arguments where the function is called that would be such a gigantic compiler bug I can't imagine that is really the case.
Also at least for gcc you can just cast the variables in the constraints, but I think clang or lock have issues with that...

More information about the ffmpeg-devel mailing list